Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cgd 34 #12

Merged
merged 18 commits into from
Sep 12, 2023
Merged

Feature/cgd 34 #12

merged 18 commits into from
Sep 12, 2023

Conversation

JaneMoroz
Copy link
Contributor

Description and impacts

  • Add 'My team' table

Jira related story

CGD-34

Screenshots

my-team

@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2023 5:21pm

@JaneMoroz JaneMoroz requested a review from Dan-Y-Ko September 7, 2023 10:43
@Dan-Y-Ko
Copy link
Contributor

Dan-Y-Ko commented Sep 7, 2023

Initial review, it looks good. However, can you rename the my-team folder to directory and also the MyTeamPage to DirectoryPage. It may sound silly, but this is just to keep it consistent with the naming in the designs.

@JaneMoroz
Copy link
Contributor Author

Initial review, it looks good. However, can you rename the my-team folder to directory and also the MyTeamPage to DirectoryPage. It may sound silly, but this is just to keep it consistent with the naming in the designs.

@Dan-Y-Ko Done!

Copy link
Contributor

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the avg hr / sprint column. There has been an update to the design. https://www.figma.com/file/OAKUcYBLP3UOaRlnKrcf1G/Chingu-Dashboard?type=design&node-id=2038-9408&mode=dev

Don't worry about the color changes, that can be taken care of in a different pr. Make sure to also take care of the placeholder text and the "user edited" value. Don't worry about the modal though.

@JaneMoroz
Copy link
Contributor Author

Can you update the avg hr / sprint column. There has been an update to the design. https://www.figma.com/file/OAKUcYBLP3UOaRlnKrcf1G/Chingu-Dashboard?type=design&node-id=2038-9408&mode=dev

Don't worry about the color changes, that can be taken care of in a different pr. Make sure to also take care of the placeholder text and the "user edited" value. Don't worry about the modal though.

@Dan-Y-Ko I think it's done 🤓

@JaneMoroz
Copy link
Contributor Author

JaneMoroz commented Sep 9, 2023

@Dan-Y-Ko Not sure about Edit Button's hover effect, looks a bit weird.

@Dan-Y-Ko
Copy link
Contributor

Dan-Y-Ko commented Sep 9, 2023

@Dan-Y-Ko Not sure about Edit Button's hover effect, looks a bit weird.

I agree. However, I think we can take care of the small details in separate prs. I don't want to hold up people's prs over every little thing. We'd never close any prs if we did that lol.

I will take note (or try to anyways) of things like this and resolve it with Eury and then either myself or someone else can fix it in a separate pr.

Just to make sure, is this what you see too: https://i.imgur.com/jkjGLgn.png

@JaneMoroz
Copy link
Contributor Author

JaneMoroz commented Sep 10, 2023

@Dan-Y-Ko Not sure about Edit Button's hover effect, looks a bit weird.

I agree. However, I think we can take care of the small details in separate prs. I don't want to hold up people's prs over every little thing. We'd never close any prs if we did that lol.

I will take note (or try to anyways) of things like this and resolve it with Eury and then either myself or someone else can fix it in a separate pr.

Just to make sure, is this what you see too: https://i.imgur.com/jkjGLgn.png

Yeah, this grey background. I can remove this hover effect by adding additional classes, maybe I can add some icon's color change on hover instead or I can just change the edit button a bit:

  • Initial state (exactly like in Figma):
    table-editBtn
  • And hover state:
    table-editBtn-hover
    OR
    table-editBtn-hover-2

@Dan-Y-Ko
Copy link
Contributor

Dan-Y-Ko commented Sep 10, 2023

@Dan-Y-Ko Not sure about Edit Button's hover effect, looks a bit weird.

I agree. However, I think we can take care of the small details in separate prs. I don't want to hold up people's prs over every little thing. We'd never close any prs if we did that lol.
I will take note (or try to anyways) of things like this and resolve it with Eury and then either myself or someone else can fix it in a separate pr.
Just to make sure, is this what you see too: https://i.imgur.com/jkjGLgn.png

Yeah, this grey background. I can remove this hover effect by adding additional classes, maybe I can add some icon's color change on hover instead or I can just change the edit button a bit:

  • Initial state (exactly like in Figma):
    table-editBtn
  • And hover state:
    table-editBtn-hover
    OR
    table-editBtn-hover-2

Eury responded saying there isn’t a hover effect so I think we can go without one. However, I do like how it looks in your 2nd screenshot

@JaneMoroz
Copy link
Contributor Author

Eury responded saying there isn’t a hover effect so I think we can go without one. However, I do like how it looks in your 2nd screenshot

Should I just change this hover effect (remove grey background)? I can add some custom classes, I think this bg color is coming from DaisyUI.

@JaneMoroz
Copy link
Contributor Author

@Dan-Y-Ko Done!

Copy link
Contributor

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Dan-Y-Ko Dan-Y-Ko merged commit e4ae6d8 into dev Sep 12, 2023
2 checks passed
@Dan-Y-Ko Dan-Y-Ko deleted the feature/CGD-34 branch September 12, 2023 17:23
Dan-Y-Ko added a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants